Silently attempt to fetch non-existent hash value #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like its better to raise on a missing attribute than to silently return nil? Seems like a way you'd get screwed on spelling errors? |
|
I'd consider that this piece of code data = [{ id: 1, content: 'hello', meta: 'meta' }, { id: 2, content: 'world' }]
json.array! data, :id, :content, :metais a shortcut for data = [{ id: 1, content: 'hello', meta: 'meta' }, { id: 2, content: 'world' }]
json.array! data do |hash|
json.id hash[:id]
json.content hash[:content]
json.meta hash[:meta]
endSo I would expect them to behave similarly. Of course we can say, that instead of json.array! data, :id, :content, :meta, fetch: true # assuming that `Hash#[]` is the default methodor json.array! data, :id, :content, :meta, silent: true # assuming that `Hash#fetch` is the default method |
|
Hm, we could even handle that completely differently and introduce json.array! data, :id, :content, :meta, default: '' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
array!method attempts to read a non-existent hash value it raises theKeyErrorerror because it usesHash#fetchmethod under the hood without the second argument.This case is not covered with tests(the Hash case is not covered at all) so I assume it is not the expected behavior.
I cannot find any arguments when this behavior might be useful.
This PR fixes this issue and makes sure an attempt to read a non-existent hash value returns
nil